London|26-ITP-Jan|Alexandru Pocovnicu|Sprint 3| Practice Tdd#942
Closed
alexandru-pocovnicu wants to merge 6 commits intoCodeYourFuture:mainfrom
Closed
London|26-ITP-Jan|Alexandru Pocovnicu|Sprint 3| Practice Tdd#942alexandru-pocovnicu wants to merge 6 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
added
the
Needs Review
cjyuan
reviewed
Feb 16, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Your PR branch is 7 commits behind CYF's repo.
Can you update your PR branch and then check if your code meets the updated spec?
Note: There will likely be merge conflict. It's probably easier to create a new branch, and transfer your code and update them on the new branch.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Done TDD by first writing tests and then implementing functions to pass those tests